Tom White
Tom White
Looking at this again I think I prefer the second option. The `by` argument (first option) has a complex interaction with windowing, which I feel might be confusing for users....
Is this ready to be merged or are you planning further changes @timothymillar?
I think the `manager` keyword will also need adding to `open_zarr`, `open_dataset` and `to_zarr`. I'm interested in trying this out on some of our genomics use cases in sgkit (see...
@TomNicholas it might be good to rebase this now that #7067 is in.
This is great feedback - thanks @keewis! I will take a look at implementing your suggestions.
Updated with all the suggestions. How does this look now?
Thanks for opening this issue @jlmelville. My goal is really to remove duplication, and have umap use the nn-descent code from this project at some point. > I am happy...
Have you got a link to where it's failing?
It looks like the warnings have started appearing from Numba 0.44. I've opened #68 to remove the ones related to `parallel=True`. There are two more to do with 'reflective list'...
The code I used for benchmarking the GWAS workload on a cluster (using #438) is here: https://github.com/tomwhite/gwas-benchmark. These benchmarks are for running on an ad hoc basis, and involve quite...