Tom Vo

Results 265 comments of Tom Vo

Hi @taylor13, thank you for your input! We are planning to carefully review your notes about weight thresholds and the "centroid" function. Here are more related comments: - https://github.com/xCDAT/xcdat/discussions/275#discussioncomment-3093644 -...

> @tomvothecoder this is interesting. No, I haven't. Maybe because my data mostly have [time, lat, lon] or [lat, lon] dimensions. It could be that the logic in `_regrid` expects...

@jasonb5 Unless this can be resolved by next Tues, we can push it back to the next release. I don't think it is a high priority because Jiwoo hasn't ran...

Example result of `_drop_incomplete_seasons()`: ```python # Before dropping # ----------------- # 2000-1, 2000-2, and 2001-12 months in incomplete "DJF" seasons" so they are dropped ds.time array([cftime.DatetimeGregorian(2000, 1, 16, 12, 0,...

Hey @lee1043, this PR seemed to be mostly done when I stopped working on it last year. I just had to fix a few things and update the tests. Would...

> @tomvothecoder Can this be considered for v0.7.0? This PR still needs thorough review before I'm confident in merging it. I'll probably tag Steve at some point. The release after...