Tom Vo

Results 265 comments of Tom Vo

Thanks for this feature suggestion Jiwoo. I agree, we should have a `skipna` flag to replicate what Xarray offers. > ### Additional context > > It would be even more...

I think an alternative solution to `skipna` is for the user to drop `nan` values before calculating the average. @pochedls any thoughts for this specific enhancement?

> @tomvothecoder @pochedls sorry that I haven't fully followed this, but just wondering if there to be any chance to follow upon this as Celine reached out for the same...

Thanks for this @jypeter. This has been discussed and was in-mind, although a GH issue was not opened for it. I explored a possible implementation similar to xarray. xarray uses...

We need to revisit this issue because we use OPeNDAP for E3SM data in our [gallery](https://xcdat.readthedocs.io/en/latest/gallery.html) notebooks. OPeNDAP might not be supported anymore by ESGF2 in the near future, specifically...

> I wonder if the `yaksa` issue is something that goes beyond dev ops. I get it when exiting iPython. I first noticed it in the [vertical regridding PR](https://github.com/xCDAT/xcdat/pull/388#issuecomment-1573978250), but...

> Also a ["yaksa: 10 leaked handle pool objects"](https://github.com/xCDAT/xcdat/actions/runs/5350601424/jobs/9703419605#step:9:50). I performed [debugging](https://github.com/E3SM-Project/zppy/pull/475#issuecomment-1678139165) for a segmentation fault in e3sm_diags introduced by `cdms2=3.1.5` patch 21 which was released two weeks ago ([PR](https://github.com/conda-forge/cdms2-feedstock/pull/89))....

> > > Also a ["yaksa: 10 leaked handle pool objects"](https://github.com/xCDAT/xcdat/actions/runs/5350601424/jobs/9703419605#step:9:50). > > > > > > I performed [debugging](https://github.com/E3SM-Project/zppy/pull/475#issuecomment-1678139165) for a segmentation fault in e3sm_diags introduced by `cdms2=3.1.5` patch...

Hi @durack1, thanks for chiming in. I rephrased this issue from "use more realistic data" to "use floating points for data (not `np.ones` or `np.zeros`). Since the unit tests just...

That would be great @durack1! We would definitely want to test edge-cases if possible. Here's an example edge-case in our test suite. It tests the weights generated for spatial averaging...