Tom Vijlbrief

Results 30 comments of Tom Vijlbrief

How did you test this? Can you reproduce the error in a (new) python test and share that code?

> I tested this on the RTL. Does an RTL testbench work for you? It's ''probably'' working correctly for the python code. I tested it on real hardware, see README....

you would have to write interface logic which converts from 1 256bit word to 8 8bit byte IO operations and uses an 8 byte buffer. The deflate algorithm is byte...

@ryanjpearson I will have a look later this week...

The PNG code makes it a bit harder to find the root cause. Could you first change your example C code to test the decompression of (EDIT): ``` static char...

> Here's a simpler implemenation using the test case you provided. Thanks! I assume you verified that the first 5 bytes are still damaged (0) and the rest of the...

Regarding the test data, why don't you just use (EDIT corrected wrong escapes): ``` static unsigned char Compressed[] = "\x18\x95u\xcf\xbb\t\x80@\x00\x04\xd1V\xd6\x0e\xdc\xf3\xdf\x81\x1d\xd8\x80\x66\x07\x07\xf6\x1f\x18\t\n;\x13N\xf6$\xedW\xadMG\xbb\xeb\xd9\xa9\xd7\xdbo;\xef\x92\xf7\x90\xf7\x98\xf7\x94\xf7\x9c\xf7\x92\xf7\x9a\xf7\x06\x1c\x62\x82\xd3\x00\x35H\rT\x83\xd5\x80\x35h\r\\\x83\xb7|\xbc\x0fjCzP"; ``` In `InitDecompress` ``` DeflateWrite(REG_DEFLATE_RESET, 1); DeflateWrite(REG_I_CLK, 0); DeflateWrite(REG_DEFLATE_RESET, 0);...

There is indeed an issue with 4 (3 reported by the compiler because it exceeds the 0-255 range) of the encoded bytes: ``` tom@swan-ubu20:~/src/HDL-deflate$ cat test.c #include int main() {...

> The output has bytes 0 through 18, 26, and 40 "zeroed" out. The rest of the bytes are what they should be. What happens if you do 2 clock...

> That made the problem go away! Thank you! That's good news! You will probably only need the extra tick when `DecompressedReadCount + 1 == GetOProgress()`