Tom Shanley

Results 23 comments of Tom Shanley

Hi Micah - thank you, it would definitely benefit from someone who knows more about modular code, and using bundle etc than me :) An aside, i'm planning an update...

sounds reasonable.. for the update function I mentioned earlier, I'm probably going to need to use addCircularPathData and its dependents (calcVerticalBuffer and createCircularPathString, while updating addCircularPathData to avoid any sorting...

Hi - thanks for the evaluating this library! There is an issue with sankeycircular compared to the original sankey library. sankeycircular has a few more layout 'optimisations', such as trying...

Yeah, I know its not ideal to have to support two libraries. Admittedly, I could include the d3-sankey, and sankeyCircular does the test for circular links and then proceed accordingly....

i may just incorporate the parts that are different and switch based on the presence of circular links. probably wouldn't inflate too much, but I will do a test. initially...

Have you installed the dependencies, including elementary-circuits-directed-graph?

It should be part of the dependencies installed when using npm install

Potential solution: Provide an option on the sankey object, eg sankey.sortNodes([fieldName]) which takes the name of field. This field would be provided in the array of node objects ( [...

re nodes which link to others nodes in the same column. Potential approaches are: 1. Don't draw the links, and leave it to the user to make sure that linked...

Re sortNodes. probably should make it so it can accept function or constant, like nodeID.