litao

Results 19 comments of litao

Hi @Apache9 @apurtell @virajjasani @ndimiduk, could you please have a look. Thanks.

I sent an email `[DISCUSS] Disable Style/FrozenStringLiteralComment for ruby` for discussing this.

Hi @Apache9 @busbey , could you please take a look? Thanks a lot.

Hi @ndimiduk , could you please also take a look. Thanks.

Hi @jojochuang @ferhui , could you please also review the code? Thanks a lot.

> @tomscut Thanks for contribution. > I'm confused here. The log is necessary or not. If it's necessary, many logs as you said drown out other logs. If it's not...

> @tomscut Thanks for comments. > > > but there are no redundancies in most cases > > I see that if shouldProcessExtraRedundancy returns true, It will enter this method....

> There are no so many logs you mentioned in our cluster of thousands of nodes. So I guess there is a hidden reason behind of it. If we change...