Thomas Saillour

Results 29 comments of Thomas Saillour

FIY, I tested the API to see if we could extract longer timeseries. Here is a test with a startdate on the 1st of Jan 2022: https://www.ioc-sealevelmonitoring.org/service.php?query=data&format=json&code=audi&timestart=2022-01-01T00:00 Here is a...

I'll look into adding a test later this week. I'll reuse when I am doing now to extract and concatenate years of data.

> The tests are failing due to reduced test coverage. We can change the minimum required threshold in pyproject.toml, but we do need to add some tests for the new...

Actually as I progress doing our Iceland [test case](https://github.com/ec-jrc/pyPoseidon/blob/master/Tutorial/MESH.ipynb), I found more bugs/fixes to implement in various functions. I agree that correcting & addressing different issues with different PR is...

Thanks @WPringle, following your post, I realized it didn't work for other resolutions. So I have done some [sensitivity tests](https://gist.github.com/tomsail/f217f354cdae9e230811ebdb1ebc0deb) on the arctic circle and ended up using the following...

I found out what was the problem. During the re-computation of the forces, we were over-constraining because there were too many points closer to the poles. I was actually trying...

The sensitivity test on the polar circle are spot on now: [here](https://gist.github.com/tomsail/5af69ced1f9608d7a2004c3d8b5c191b) is the latest version of the notebook

Good point. I could provide an example for Iceland, Greenland and see the differences with/without that correction. I'll do it later though. I have no rush to merge this right...

Hi @WPringle and @krober10nd, It's been a while, but I had some time to look at this. I have tried to implement the distorsion and see how it impacts the...

In conclusion: - the PR #76 addresses this issue only for global meshes. - there would be more investigation needed for distortion and meshing close to polar locations. - I...