pucauto icon indicating copy to clipboard operation
pucauto copied to clipboard

Pucauto Commits to Send Copies You Don't Have

Open XVicarious opened this issue 8 years ago • 7 comments

There isn't much I can do to prove or show this happening (as it always happens while I'm away or not looking), but Pucauto will commit to send multiple copies of cards I don't have.

For example last week it commit to send someone two copies of the new Olivia to someone even though my haves list only had one copy on it. The same thing happened with a copy of Shard Volley.

The output tells me it found x trades to someone with y points and then shows the card on the list twice.

XVicarious avatar Apr 26 '16 15:04 XVicarious

I have seen this several times, but it's not a PucAuto problem. I have confirmed that this occurs with other tools (e.g. PucaPower), and I've also seen it when manually looking at the trades page on PucaTrade without any other tool support. I've seen it in Firefox and in Chrome too. I've even submitted the bug to PucaTrade. I think it's entirely in the AutoMatch feature with a possible interaction with the infinite scroll feature they use.

eengstrom avatar Apr 26 '16 16:04 eengstrom

This problem comes and goes, and I truly believe it is on PucaTrade's end. I too have seen it on the Send Cards page when using it manually without using any sort of bot or tool.

tomreece avatar Apr 26 '16 21:04 tomreece

I figured it out. I went to the send cards page, loaded up everything and ran the following Javascript:

$('table tr').each(function(){ console.log($(this).attr('id')); });

I then sorted, created a copy, and removed any duplicate lines. There was one. So basically, cards that have been duplicated by PucaTrade's DataTables code will have the same ID attribute on the row. So all that needs to be done is to check row IDs to make sure you're not committing to send an identical trade.

XVicarious avatar Apr 27 '16 17:04 XVicarious

Awesome. I'll get an extra check in for this ASAP to fix their problem.

tomreece avatar Apr 29 '16 19:04 tomreece

Any word on this? If you are busy I might be able to find the time to do this today.

EDIT: I am working on this now. Almost done.

XVicarious avatar May 21 '16 15:05 XVicarious

I'm dumb and don't know how to rebase apparently. Or reference. Or branch. Silly me pull request 87.

XVicarious avatar May 21 '16 17:05 XVicarious

Hey, I found another source of puca double commits. When scrolling, Puca will occasionally load additional copies of a card you don't have enough of from a user right along the scroll border. I haven't found any way to fix this without using the export feature available to Uncommon users, but I figured this might be useful.

drakeblood4 avatar Jun 18 '16 13:06 drakeblood4