Tom Scanlan

Results 25 comments of Tom Scanlan

Looks appropriate to me. This recently popped up in running through note to install on cloud pks. I needed to adjust the values.yaml directly over generating it with this script

@richardboswell 1. the doc says to run site.yml, which calls base.yml in turn. Does that not cover your needs? 1. if not, lets consider making a new top level play...

+1. Using 3.3.0 containers with internal and external listeners. Same error, I haven't found a work around.

Hi @tbillington I really like the project idea. Cleaning my code archive is something I do frequently, or I tend to run out of disk. I think I saw #97...

Thanks, I use tests to help understand what's going on, and it grew from main, so I ended up testing from the wrong place. I'm really trying to isolate parts,...

ok... done with changes for a few hours @tbillington. Thoughts?

Hey @tbillington, Thanks for the feedback. I'm still really new to rust, so I haven't used clippy. I'll look into it. Thanks. re: Specify test in kondo-lib I'm intending to...

Ok... think I'm following on where I was testing from kondo into the lib for clean(). I moved that kondo-lib, but still seeing need for the discover() test to remain...

Review what's here at your leisure once more and I'll make another pass before rebasing again. A part I'd like to change. but I'm not sure if I'll get to...

I think I got to almost all your feedback. I like the wrapper idea and played with it. Ready for feedback.