Tom Parrott
Tom Parrott
> The protobuf change will have to be in the same commit I meant the change to the current protobufs but using the new protoc command that introduces the extra...
Excellent! Although we would still like a separate commit for changing to the new protoc before any other changes were made so that the differences introduced by removing the definitions...
> Oops I think I misunderstood what you wanted me to do. To clarify before I redo the commits again: > > 1. Run protoc on the old `migration.proto` and...
jenkins: test this please
@masnax thanks I'll take a look at this ASAP
> ```go > // A handwritten statement fetching all the certificates matching the project and fingerprint. > var certificateObjectsWithProjectIDByFingerprint = RegisterStmt(` > SELECT * FROM certificates > JOIN certificates_projects ON...
An additional thing I've often wondered about the DB generator (given its aim is to reduce manually written boiler plate code) is why do we need to write define every...
> That particular statement will only execute if `filter.Fingerprint` is not nil. So I would have to define my custom SQL statements for every possible combination of the filters?
> No, `lxd-generate` is capable of parsing the non-filtered statement to produce filtered ones. So you would write `certificateObjectsWithProjectID` and then a generator comment with `objects-by-Fingerprint` would generate a new...
> I think we can get around this by a) generating a string `Columns` for use in handwritten statements containing the columns we need to select fully populate the type,...