Tom Parrott

Results 1094 comments of Tom Parrott

I suppose if the lxd tests pass OK then it should be fine

There are also tests in this repo that check that the result set iterators return io.EOF at the end of the rows, so if they pass that will be encouraging....

> I will handle the dqlite leadership loss in a different way than closing the connection. Which way are you thinking?

The proposed command would try and set the `description` config key rather than the object's `Description` field. e.g. `lxc config set c1 description foo` would potentially be a valid command...

> I suspect whatever we do will feel like a hack unfortunately. I suppose we could have `lxc set description=foo` and just ensure that we never use `description` in an...

Ah OK that makes the decision easy then :)

The ACL on bridge networks doesn't support intra-bridge filtering (see https://linuxcontainers.org/lxd/docs/master/howto/network_acls/#bridge-limitations). I think you are saying that you would expect the proposed ACL to block ping traffic between instances connected...