Tom

Results 122 comments of Tom

Happened to me here: https://app.travis-ci.com/github/cilium/cilium/jobs/572773089

@NikhilSharmaWe General approach looks ok, looks like the build is failing though. Couple of comments as well.

@christarazi Can you take a look to see if this adequately solves the issue at hand.

@NikhilSharmaWe not sure what the problem with lint is, maybe check https://docs.cilium.io/en/stable/contributing/development/dev_setup/ to make sure you have the right dependencies installed etc. The branch CI will also do lint checks...

@NikhilSharmaWe If you rebase the CI, that should fix the current build failure.

/test Job 'Cilium-PR-K8s-1.23-kernel-4.19' failed: Click to show. ### Test Name ```test-name K8sChaosTest Connectivity demo application Endpoint can still connect while Cilium is not running ``` ### Failure Output ```failure-output ```...

Thanks for the PR! Could you split this PR into two commits such that both issues being fixed are separate commits. I'm finding it hard to follow what changes belong...

On the topic of bucket sizes for these, why are our so many of our metrics, including these, denoted in `_seconds`. A lot of these sound like their will often...

@jrfastab Is this still relevant? I'm looking for some easy issues to get started learning about datapath.