Tom

Results 25 comments of Tom

@jief666 well. I'm interested in new features but better as a part of darling-dmg, it's a mature project which I use for quite a while... Whould be great to see...

Without the check m_descriptorData[0] is trying to access the first element of the vector while the vector is empty.

Thanks for confirming. Quick code to reproduce: ```cpp HFSBTreeNode retEmptyNode() { return HFSBTreeNode(); } HFSBTreeNode crashNode; crashNode = retEmptyNode(); // oops ```

Windows, Visual Studio 2013

This is already implemented here: https://github.com/sgan81/apfs-fuse/blob/master/ApfsLib/DeviceDMG.cpp You could use this approach.

What do you think? [EncryptedReader.cpp](https://gist.github.com/tomkoen/247a41cb82886f69602a31dd7ee3d13d) [EncryptedReader.h](https://gist.github.com/tomkoen/8fd7d5414dbb808f1bf8f65a3d52f654)

And here goes this ```cpp #ifdef COMPILE_WITH_DECRYPTION_SUPPORT #include "decrypt/EncryptedReader.h" #endif #ifdef COMPILE_WITH_DECRYPTION_SUPPORT DMGDisk::DMGDisk(std::shared_ptrreader, const std::string &password) #else DMGDisk::DMGDisk(std::shared_ptrreader) #endif : m_reader(reader), m_zone(40000) { #ifdef COMPILE_WITH_DECRYPTION_SUPPORT if (EncryptedReader::isEncryptedDMG(reader)) { auto encReader...

@bugaevc, sorry I don't get it. Which messages are duplicated? 😨

no chance to merge this? I've used this code for years without any problems (and without openSSL 😄 )

@bugaevc @LubosD guys the pull request is >3 years, you don't close it and don't reply, is something wrong with it? I could fix. If C code is not nice,...