Tomi Virkki

Results 63 comments of Tomi Virkki

This seems to be a bug in the `` web component. In this state the component's `opened` value is `true`, while there's no notification overlay visible. Adapted the repro as...

Hi @Springrbua, this is because of the `em` units used for the column width. `em`'s are based on font size and with Material, the header and body have different font...

> Before toggling the control, the reported activeElement is details-basic-imported. That this is not the element is, I believe, a limitation of Chrome's developer tools console when interrogating shadow DOM...

This could be fixed by adding [safe triangles](https://height.app/blog/guide-to-build-context-menus#safe-triangle) support to Vaadin menu components

To use private API in the tests, we can either use Casting to `any` ```ts (grid as any)._isExpanded('foo'); ```` Or defining a test type for the Private API: ```ts type...

> According to latest a11y review by TetraLogical, This problem seems to persist in V24.2.alpha4. Tested the ComboBox example on Vaadin docs (latest 24.2) and didn't have any issues selecting...

This is not a clean workaround but it does the job at least in the case of the provided example: place the following inside the value change listener: ```java treeGrid.getElement().executeJs("queueMicrotask(()...

Possibly related to https://github.com/vaadin/web-components/issues/6974#issuecomment-1867309522

I'd vote for deprecating the `setClassNameGenerator` method. It's already [deprecated](https://github.com/vaadin/web-components/blob/d7eeba21faa58cb17286e17095bbe3feae08fa2e/packages/grid/src/vaadin-grid-styling-mixin.js#L32) in the web component API

I'm not sure if exposing `Tabs` in `TabSheet` is a good idea. Giving the user full control over the internal component may lead to unexpected results. For example, with the...