flow-components
flow-components copied to clipboard
Fixed JavaDocs
Description
This method is 100X easier to find than the partName variant that most people should be using. Added disclaimers and link to that.
Last time discussed here:
https://vaadin.com/forum/t/styling-individual-cells-in-a-grid-v24/166135/5
Type of change
- [x] Bugfix
- [ ] Feature
Checklist
- [ ] I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
- [ ] I have added a description following the guideline.
- [ ] The issue is created in the corresponding repository and I have referenced it.
- [ ] I have added tests to ensure my change is effective and works as intended.
- [ ] New and existing tests are passing locally with my change.
- [ ] I have performed self-review and corrected misspellings.
- [x] I have not completed some of the steps above and my pull request can be closed immediately.
Additional for Feature type of change
- [ ] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.
TC Format Checker Report - 05:39 - 03 - May
There are 1 files with format errors
-
To see a complete report of formatting issues, download the differences file
-
To fix the build, please run
mvn formatter:formatin your branch and commit the changes. -
Optionally you might add the following line in your
.git/hooks/pre-commitfile:mvn formatter:format
Here is the list of files with format issues in your PR:
vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java
Drafted this quickly with browser & GitHub, not planning to continue on this. So reviewer, please fix formatting or make some alternative fix for the issue. If I'd know the dark history, I would have deprecated this method as well.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
I'd vote for deprecating the setClassNameGenerator method. It's already deprecated in the web component API
Well then it sounds like it is a bug that this Java method is not deprecated.