Tomás Chor

Docs for AMD support.

4

Hi, I'm curious as to what is the status of AMD support in this package. The words NVIDIA or AMD do not appear once in the docs (based on the...

Moves masking fields from model update to output writers when using ImmersedBoundary

19

This PR removes the masking of tracers when using IBM. At the moment all tracers are masked inside immersed solids. It's my understanding that these masked values aren't being used...

Pretty minor issue but `\ref{sec:fractional-step}` isn't rendering in the docs: https://github.com/CliMA/Oceananigans.jl/blob/2edd2b1fa321725ad4e7891d3442ca9dd0657d98/docs/src/numerical_implementation/elliptic_solvers.md?plain=1#L46 I couldn't figure out what that's supposed to link to, so I couldn't fix it myself.

Adds grid metrics to NetCDF output

12

This PR adds grid spacings to NetCDF out, which is a step closer to solving https://github.com/CliMA/Oceananigans.jl/issues/1334 EDIT: The goal here is to add grid metrics to NetCDF output. The are...

Update Coord system and Notation page in docs

6

I think [Coordinate system and notation](https://clima.github.io/OceananigansDocumentation/stable/physics/notation/) page in the docs needs to be updated. First, we don't only use a Cartesian grid anymore (we don't even use the word Cartesian...

Fixes output construction for sliced `Field`s

26

This PR fixes the behavior seen in https://github.com/CliMA/Oceananigans.jl/issues/2497 Basically due to the behavior of `construct_output()` and the default values for `indices` in the output writer constructors, whenever we pass a...

Cannot create output writer when output contains a sliced `Field`

3

I'm encountering an odd behavior when creating a `NetCDFWriter`. In the example below `writer2` gets created successfully, but `writer1` does not. ```julia using Oceananigans N = 4 grid = RectilinearGrid(topology...

Should we explain `fill_halo_regions!()` in the docs?

7

`fill_halo_regions!()` seems to be a very important function in Oceananigans. I've never needed to use it in any script, but based off of some discussions/issues/PRs here it seems like there...

Reorganizing examples in the docs

11

As pointed out in https://github.com/CliMA/Oceananigans.jl/issues/2309 the examples are taking too long to build, which isn't good. One option is already pointed out in https://github.com/CliMA/Oceananigans.jl/issues/2309, but another one is to decrease...

The definition of `gravity_unit_vector` apparently doesn't match it's name

10

I have recently realized that the current definition of `gravity_unit_vector` is a vector that's in the _opposite_ direction to gravity: https://github.com/CliMA/Oceananigans.jl/blob/10a9479ec462f4f5f053e7447ff667fdfe20542d/src/BuoyancyModels/buoyancy.jl#L11-L13 This sounds counter-intuitive to me. I wonder if we...