Tomás Mota

Would recommend merging this after #62 , such that golangci-lint does not timeout

just saw your review a year later @turkenh , not sure if this is still good to merge 😅

> Thanks for opening the PR! I left some suggestions: > > * String sets are typically represented in Go with the type `map[string]struct{}. I left some suggestions to do...

> For testing you can replace the logger with https://pkg.go.dev/go.uber.org/zap/zaptest/observer That's what I wanted to do, but then I need to pass down the logger in ConverterSettings instead of hardcoding,...

> @tomasmota is this ready for another review? Yes, and sorry about the mess of commits, I messed it up and got too lazy to reset properly. guess you will...

I'll take a stab at it when I get the time :) thanks for the indications!

> Code looks great! Would you be up for writing some tests? You can write a function for testing like this: > > ```go > func NewTestConverter() (confmap.Converter, observer.ObservedLogs) {...

@mx-psi i think you can review, I addressed your comments directly.

@mx-psi I added a test with what I understood you were asking for, not sure it was exactly that you meant 😅

Great, really appreciate your help and patience!