Tomas Bjerre

Results 402 comments of Tomas Bjerre

Dont you have all the things you need to construct the URL yourself? ``` {"jobs":{"refjob":{"regexpFilterExpression":"","triggered":true,"resolvedVariables":{"ref":""},"regexpFilterText":"","id":1,"url":"queue/item/1/"}},"message":"Triggered jobs."} ```

I would expect there to be some way to, given `SchemaValidatorsConfig` or `JsonSchema`, add a keyword. I have a custom keyword in my schema that I use in a `JsonSchemaWalkListener`:...

I think this was fixed when fixing https://github.com/tomasbjerre/violations-command-line/issues/7

This library uses this implementation of Handlebars: https://github.com/jknack/handlebars.java I do not see any length helper in those docs. How do you want to use substring? What is the original value...

Thanks for reporting. Good that you found a workaround.

> @tomasbjerre Any chance to look at this? @jennifer-shehane you probably tagged the wrong Tomas. But I think it looks great :)

No, now it will always put all violations in the `codeClimateFile`. But it can be implemented. Perhaps best to add a `diffCodeClimateFile` config.

Perhaps some of the API comments here would have been avoided if the things that are considered API is in its own Gradle project, as discussed in https://github.com/wiremock/wiremock/issues/2266 .

> Requesting changes, There is a bunch of API breaking changes that are IMHO not needed. QUite opposite, maybe it is better to have a `withFailIfMultipleMappingsMatch(boolean)` notation and to take...