cypress
cypress copied to clipboard
cypress-io
fix: --spec now allows () in filename
- Closes https://github.com/cypress-io/cypress/issues/28509
Additional details
Even though there was an existing workaround, it is easier to just allow parenthesis.
PR Tasks
- [x] Have tests been added/updated?
- [na] Has a PR for user-facing changes been opened in
cypress-documentation? - [na] Have API changes been updated in the
type definitions?
- Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Is there anything I should do since the check for ''Semantic Pull Request'' is failing?
@AtofStryker That's a good call out. This bug only happens when you have a closing paren DIRECTLY following an opening paren, so () not (a). I don't think that would be a valid usecase in any globs 🤔 , so escaping them back to back should be fine. That's what I'm thinking.
@jennifer-shehane is the failure in CI legit in relation to the glob changes?
@tomasbjerre Any chance to look at this?
@jennifer-shehane you probably tagged the wrong Tomas. But I think it looks great :)
I'm sorry, have had a lot of work lately. By tomorrow I will check it.
@TomasTeixeira2003 Just pinging to check in on these updates again.
@TomasTeixeira2003 Any chance you'll be able to fix this PR? We'll need to close otherwise.
I've been working on another feature to rerun failed tests and didn't remember about this. Sorry. By Sunday i will have it working.
@TomasTeixeira2003 The instructions are here: https://github.com/cypress-io/cypress/blob/develop/system-tests/README.md
@jennifer-shehane if I pass the spec file without any blackslash before the parenthesis, bash doesn't even accept the command. But if i do it with the backslash it does work.
I don't know what more i can do since my machine allows me to run the spec this way.