Tomás Andróil comments

Results 5 comments of


                                            Tomás Andróil

Fix logic mismatch in `newR1C` for better Groth16 optimization

Quick heads-up on PR #1482 (“fix(update): Correct logic mismatch in newR1C for better Groth16 optimization”): - Align the swap condition in `newR1C` with the intended goal of minimizing B-matrix variables...

fix(pstoreds): Fix cyclic batch threshold handling and add error checking for peer ID decoding

@MarcoPolo I have added the requested unit tests for both cyclic batch threshold handling and peer ID decoding error handling

fix(pstoreds): Fix cyclic batch threshold handling and add error checking for peer ID decoding

Hi @MarcoPolo! Quick reminder about PR #3274 (“fix(pstoreds): Fix cyclic batch threshold handling and add error checking for peer ID decoding”): - Correctly initialize `cyclicBatch` threshold to avoid premature commits...

optimize slashing protection interchange import

Quick reminder about PR #7312 (“optimize slashing protection interchange import”): - Switched signed_blocks selection from O(n log n) sort to an O(n) scan for max slot - Removed redundant signed_attestations...

optimize slashing protection interchange import

@tersec Thanks for the review! I’ve addressed the feedback: - Removed the stray inline commentary. - Restored the pruning explanations for blocks/attestations. - Re-added the formal proof link and the...