kitti2bag icon indicating copy to clipboard operation
kitti2bag copied to clipboard

Force install a py2 compatible version of pandas

Open LiyouZhou opened this issue 5 years ago • 6 comments

kitti2bag depends on pykitti which depends on pandas which deprecated py2 support in 0.24 causing breakage in the docker build. This patch works around this issue by first installing a py2 compatible version of pandas before installing kitti2bag.

LiyouZhou avatar Nov 26 '19 11:11 LiyouZhou

travis failing with same error on master. https://travis-ci.org/tomas789/kitti2bag/builds/610976165?utm_medium=notification&utm_source=github_status

LiyouZhou avatar Nov 27 '19 12:11 LiyouZhou

Confirmed this fix for the docker image build

mjshiggins avatar Dec 11 '19 23:12 mjshiggins

anybody willing to give it a merge?

LiyouZhou avatar Jul 07 '20 10:07 LiyouZhou

@amtagrwl thanks for the review. Somehow merge is still blocked?

LiyouZhou avatar Jul 07 '20 22:07 LiyouZhou

@LiyouZhou Yeah. Travis CI fails. Could you please confirm that the pull request builds?

amtagrwl avatar Jul 09 '20 16:07 amtagrwl

@amtagrwl verified today that this pr builds and master is still broken.

LiyouZhou avatar Jul 09 '20 21:07 LiyouZhou