Tom Alexander

Looks like this bug was introduced in https://github.com/goharbor/harbor-helm/commit/c34ab1d336d3f5ff7edb51068381a0be63d2c8ad which means its been in every release of harbor-helm since 1.4.0

Hey, sorry that took so long. Ran into an old friend I hadn't talked to in over half a decade and I've been recovering from that hangover.

Thanks for taking a look! That behavior was my intent, but I just checked and you're right. The other take_until* macros throw an error if theres no match. I'll revise...

Ah sorry. Since posting this merge request I haven't found time to update it (changed jobs, sister's wedding, etc). FWIW this is a feature I still want but I can't...

Hey, back from the dead. I'm loving the switch to functions in nom version 5! I've updated the PR the latest master, rewrote it as a function instead of a...

I thought about it some more and I decided to add in a `take_until_parser_matches_and_consume` because I realized its a performance thing. As in, `terminated(take_until_parser_matches(foo), foo)` still has to run the...

Hey, I just made a small design change, so I want to call it out here to make sure that the project is aware of it and agree with it....

I think its important to point out the difference between this and `many_till` since the two are very similar parsers. `many_till` works by running the first parser and then checking...

Hey thanks for the report and the suggested change! I'll try to look at it this weekend (I'm taking vacation days this week to work on a side project so...

Thanks! I like the change. The only change I needed to add was for checking the parser after the input has been exhausted.