tomalakgeretkal

Auto-reload doesn't work; manual reload doesn't work

4

Blurb suggests documents are auto-reloaded when changed, but this doesn't happen for me. In addition, although there's no "Reload" option on the File menu, I just found a "Reload" option...

Fixed basic_json::diff and basic_json::patch not compiling with custom string type (#4134)

5

Note that this has yet to be amalgamated (waiting for #4083).

patch_inplace assumes StringType is std::string

1

### Description `patch_inplace` has several instances of `get`, which breaks the build if you're using a custom string. ### Reproduction steps - Instantiate a nlohmann::basic_json with a custom string type...

Turn on compiler warnings - this function returns a reference to a local variable. Looks like returning by value will do.

Usage example casts string literal to `char*`, which is not a good thing to do (there is a reason we have `const char*` here!). It's needless anyway because `Lookup` takes...