Pierre Krieger

> Thread that inspired this: https://www.reddit.com/r/rust/comments/83oo29/what_are_the_most_welldesigned_rust_apis/ To me the conclusion of this reddit post, with the exception if serde, is that people like functional programming.

Sorry to come to this PR, but it goes against the mental model that I have of how BABE works. > warp sync to finalized block B90 > current epoch...

I also don't understand this line: > resumes on epoch E20. And restores the epoch changes tree from aux data. You don't "resume on epoch 20". To me the epoch...

Thanks, I see. Am I right that the `epoch_index` serves no real purpose anymore (as it can always be computed on the fly from the slot number), and is kept...

This is not in the diff, but I would suggest to copy-paste the following line: https://github.com/paritytech/substrate/blob/07e1b6d72747f3cde49e85e4ff68ff158daebe16/client/network/src/discovery.rs#L662-L666 And put it here as well: https://github.com/paritytech/substrate/blob/07e1b6d72747f3cde49e85e4ff68ff158daebe16/client/network/src/discovery.rs#L696 (except without the word `external`) This is...

> sorry had to force push to do [#12529 (comment)](https://github.com/paritytech/substrate/pull/12529#discussion_r1027656190) It doesn't matter now, but you didn't have to do that. We squash commits anyway, so whether you're based on...

Unless someone comments here or on the forum, let's ship without the bandwidth, provided an issue is opened to keep track of this.

What is blocking this PR? To me it was ready already back in November.

Opened https://github.com/w3f/PPPs/pull/5 I've added a `includeDescendants` field for keys, for which the server must also include the list of all children of that key. This is important in order to...

(I'm no longer working for Parity) > On connection we could negotiate some shorter name, or just an integer and use that instead. Please don't change the wire protocol names...