substrate icon indicating copy to clipboard operation
substrate copied to clipboard

Key storage proof v2

Open cheme opened this issue 3 years ago • 3 comments

This PR adds light client call as describe in https://github.com/paritytech/substrate/issues/10623 .

I only diverge from proposed spec at https://github.com/w3f/polkadot-spec/issues/590 by renaming required bytes hash = 1; in child trie description to required bytes name = 1; : so it is the same as the former storage_key but without prefixing.

Using child trie root hash sounds like a good idea but is not consistent with specifying a block number in the request.

When writing it I also did wonder if we should allow doing the query on multiple child trie (would be a bit of change in the format but pretty ok).

I also did remove the storage cache from the source (should have been removed already I think).

cheme avatar Dec 05 '22 15:12 cheme

I also did remove the storage cache from the source (should have been removed already I think).

Yes, looks like some bad merge brought it back.

bkchr avatar Dec 07 '22 15:12 bkchr

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 06 '23 23:01 stale[bot]

not stale.

cheme avatar Jan 11 '23 10:01 cheme

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 10 '23 21:02 stale[bot]

not stale

cheme avatar Feb 11 '23 08:02 cheme

Opened https://github.com/w3f/PPPs/pull/5

I've added a includeDescendants field for keys, for which the server must also include the list of all children of that key. This is important in order to implement for example state_getKeys on a light client.

tomaka avatar Feb 21 '23 10:02 tomaka

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 24 '23 00:03 stale[bot]

Switched to "In Progress", as I will also integrate proposed changes from https://github.com/w3f/PPPs/pull/5 (prefix range query, restart and possibly ordering of keys).

cheme avatar Mar 27 '23 11:03 cheme

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 26 '23 13:04 stale[bot]

Will open a new one with things for https://github.com/w3f/PPPs/pull/5

cheme avatar Apr 26 '23 13:04 cheme