Pierre Krieger

Results 575 comments of Pierre Krieger

I have no idea what causes this, but https://github.com/paritytech/smoldot/pull/2631 improves the error message. It might also have been accidentally fixed by a couple of PRs since then. I'm going to...

It seems that NodeJS 12 doesn't support `await` in `prepare.mjs`

Actually, this can easily be bypassed.

Debian and Ubuntu stable still ship it by default: https://packages.debian.org/bullseye/nodejs https://packages.ubuntu.com/jammy/nodejs

Why not? If there are 5 lines of code to change, then it's worth it.

Going to merge. To me, there's no reason to upgrade NodeJS if necessary. If we could easily support NodeJS v1, we would. It's just a matter of trade-off, as we...

We have an indirect dependency through `criterion`: https://github.com/bheisler/criterion.rs/issues/534

Not super important considering that we only connect to Substrate nodes anyway, and these Substrate nodes will do this for us. Would be important if multiple smoldot nodes connect to...

Apparently Substrate restores what's below `__heap_pages` instead of zero-ing what's above.

For context I haven't merged this, because the last time I tried these changes considerably slow down the blocks verification speed of the full node (something like 50 times slower...