smoldot icon indicating copy to clipboard operation
smoldot copied to clipboard

Downgrade CI from NodeJS v14 to v12

Open tomaka opened this issue 2 years ago • 8 comments

NodeJS v12 is still widely used, so let's check for compatibility with that version.

tomaka avatar Jul 15 '22 15:07 tomaka

It seems that NodeJS 12 doesn't support await in prepare.mjs

tomaka avatar Jul 15 '22 16:07 tomaka

Actually, this can easily be bypassed.

tomaka avatar Jul 15 '22 16:07 tomaka

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

github-actions[bot] avatar Aug 12 '22 14:08 github-actions[bot]

Node v12 is no longer officially supported. We should not adjust code based on that version.

wirednkod avatar Aug 12 '22 15:08 wirednkod

Debian and Ubuntu stable still ship it by default: https://packages.debian.org/bullseye/nodejs https://packages.ubuntu.com/jammy/nodejs

tomaka avatar Aug 12 '22 15:08 tomaka

Debian and Ubuntu stable still ship it by default: https://packages.debian.org/bullseye/nodejs https://packages.ubuntu.com/jammy/nodejs

Im not sure that this is a good enough reason to keep supporting such versions and roll our code back accordingly

wirednkod avatar Aug 12 '22 15:08 wirednkod

Why not? If there are 5 lines of code to change, then it's worth it.

tomaka avatar Aug 12 '22 15:08 tomaka

Why not? If there are 5 lines of code to change, then it's worth it.

I just dont find it useful to support a version that is long expired (I think end of lifetime was somewhere at the end of April)

wirednkod avatar Aug 12 '22 16:08 wirednkod

Going to merge. To me, there's no reason to upgrade NodeJS if necessary. If we could easily support NodeJS v1, we would. It's just a matter of trade-off, as we can't use features that have been introduced in later sessions. Here, we have 5 lines of code to change to support NodeJS 12, so it's worth it.

tomaka avatar Aug 19 '22 16:08 tomaka

Im not strictly against of keeping the older version support. Just added my 2 cents here.

wirednkod avatar Aug 19 '22 16:08 wirednkod