Yewen Fan

Results 36 comments of Yewen Fan

And btw, did you check the p-values / coefficient produced by the codebase make sense? I remembered we figured out a bug by noticing p-values not making sense.

To add comments on how p-values are generated, here is an example: https://github.com/cmu-phil/causal-learn/pull/59/files Something like: "# All the benchmark results of loaded files (e.g. "./TestData/benchmark_returned_results/") # # are obtained from...

> > And btw, did you check the p-values / coefficient produced by the codebase make sense? I remembered we figured out a bug by noticing p-values not making sense....

After you check the p-values and think they make sense, then I can think we can push this PR.

@kunwuz could you help merge this PR?

Thanks for the awesome work, @zhi-yi-huang !!!! This is great and really non-trivial, you fixed a tons of bugs that makes the package significantly better! One final thing: since you...

yeah, for this PR, after @zhi-yi-huang run all other tests, we can push it.

@MarkDana could you help review the failed PC tests in this PR? :)

@zhi-yi-huang any updates? :) Did you find the bug? Hopefully to merge this PR in the near future to make causal-learn better!

@zhi-yi-huang Thanks so much for your awesome! I can definitely see you spent lots of efforts on this PR and this is definitely not a trivial task. Just to make...