Matthew Riley MacPherson
Matthew Riley MacPherson
Looks good. I'm guessing we don't have any GA events defined yet for this banner, but we should probably add those as well in a follow-up issue 😅 (If we...
ACs are good, moving to IB 👍🏻
@aaemnnosttv @benbowler I have it on my todo list to create issues for the subtle notification component to standardise it. The reason we didn't from the outset was I wanted...
From the context/ACs here, would there be a separate, inline script if the user was using two ICE scripts (eg. using two ICE-supported plugins)? Why output the script inline instead...
Just one question really, when you say a “proxy function”, do you mean an [actual JS Proxy](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy)? Or do you just mean that our scripts should include/reference the new trackEvent...
Sounds good, moving to IB 👍🏻
@benbowler I think it makes sense to add those here. I'll do that in the PR, it's not a big deal to include 🙂 EDIT: Never mind, they were included...
ACs here make sense, I think this should be fixable by setting the module to be Analytics _instead_, as long as that won't break things for users who only have...
@jimmymadon The approach here will work, but thinking about it, it seems to sort of "hide" the _intention_ of the modules attribute there. We don't really want/need to register those...
ACs here look good 👍🏻