AFFiNE icon indicating copy to clipboard operation
AFFiNE copied to clipboard

fix(core): should sync name after renaming in pdf embed view

Open fundon opened this issue 1 year ago • 2 comments

https://github.com/user-attachments/assets/f6a3d7b8-9ae3-4d8f-833f-d7aca1e0fffa

fundon avatar Dec 27 '24 14:12 fundon


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

fundon avatar Dec 27 '24 14:12 fundon

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.49%. Comparing base (580e3eb) to head (569e633). Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9398      +/-   ##
==========================================
- Coverage   51.50%   51.49%   -0.02%     
==========================================
  Files        2150     2150              
  Lines       97006    97006              
  Branches    16202    16201       -1     
==========================================
- Hits        49960    49949      -11     
- Misses      45663    45674      +11     
  Partials     1383     1383              
Flag Coverage Δ
server-test 78.14% <ø> (-0.04%) :arrow_down:
unittest 30.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 27 '24 14:12 codecov[bot]

Merge activity

  • Dec 30, 3:11 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 30, 3:42 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Server Test').
  • Dec 30, 4:39 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 30, 5:10 AM EST: A user merged this pull request with the Graphite merge queue.

graphite-app[bot] avatar Dec 30 '24 08:12 graphite-app[bot]