AFFiNE icon indicating copy to clipboard operation
AFFiNE copied to clipboard

feat(editor): store real color values in edgeless

Open fundon opened this issue 1 year ago • 3 comments

What's Changed!

  • adds theme type: ThemeSchema
  • adds default theme: DefaultTheme
  • stores real color values

fundon avatar Dec 23 '24 08:12 fundon


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

fundon avatar Dec 23 '24 08:12 fundon

Codecov Report

Attention: Patch coverage is 48.84615% with 133 lines in your changes missing coverage. Please review.

Project coverage is 51.46%. Comparing base (a5641ae) to head (b9f2650). Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ock/widgets/element-toolbar/change-shape-button.ts 49.01% 22 Missing and 4 partials :warning:
...widgets/element-toolbar/change-connector-button.ts 11.53% 23 Missing :warning:
...ock/widgets/element-toolbar/change-brush-button.ts 0.00% 15 Missing :warning:
...ock/widgets/element-toolbar/change-frame-button.ts 12.50% 14 Missing :warning:
...-block/widgets/element-toolbar/change-text-menu.ts 0.00% 9 Missing :warning:
...k/edgeless/components/color-picker/color-picker.ts 0.00% 8 Missing :warning:
...ot-block/edgeless/components/color-picker/utils.ts 12.50% 7 Missing :warning:
...ck/edgeless/components/toolbar/shape/shape-menu.ts 0.00% 7 Missing :warning:
...lock/widgets/element-toolbar/change-note-button.ts 53.84% 5 Missing and 1 partial :warning:
...t-block/edgeless/components/color-picker/button.ts 50.00% 3 Missing :warning:
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9254      +/-   ##
==========================================
- Coverage   51.53%   51.46%   -0.08%     
==========================================
  Files        2148     2150       +2     
  Lines       97004    96993      -11     
  Branches    16243    16201      -42     
==========================================
- Hits        49992    49913      -79     
- Misses      45628    45699      +71     
+ Partials     1384     1381       -3     
Flag Coverage Δ
server-test 78.13% <ø> (ø)
unittest 30.88% <41.15%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 23 '24 14:12 codecov[bot]

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                        EntryPoint: app                        @@
##                     canary …s_in_edgeless                 +/- ##
===================================================================
< Bundle              24.3 MB        24.3 MB    +10.6 kB(+0.04%)   
< Initial JS          10.6 MB        10.7 MB    +11.6 kB(+0.11%)   
< Initial CSS          260 kB         260 kB      +431 B(+0.17%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   91             91                       
= Chunks                   89             89                       
< Packages                269            270                  +1   
= Duplicates                4              4                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting                                              

perfsee[bot] avatar Dec 24 '24 09:12 perfsee[bot]

Merge activity

graphite-app[bot] avatar Dec 30 '24 03:12 graphite-app[bot]