toeverything
feat(core): prevent the floating sidebar from showing immediately after the sidebar is closed
close PD-1763
https://github.com/user-attachments/assets/a8346098-5f87-4297-bdb6-885f5486ce78
Your org has enabled the Graphite merge queue for merging into canary
Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.
You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.
![graphite-app[bot] avatar](https://avatars.githubusercontent.com/in/158384?v=4 "Published by a pub.dev verified publisher"){kind=small}
- #8531
👈 canary
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @JimmFly and the rest of your teammates on Graphite
☁️ Nx Cloud Report
CI is running/has finished running commands for commit d1783b6f8cbd01dd4947d7595a4ad10b3d2b4e60. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 6 targets
nx test:coverage @affine/monoreponx build @affine/native -- --target x86_64-pc-windows-msvc --use-napi-crossnx build @affine/native -- --target aarch64-apple-darwin --use-napi-crossnx build @affine/server-native -- --target x86_64-unknown-linux-gnu --use-napi-crossnx build @affine/native -- --target x86_64-unknown-linux-gnu --use-napi-crossnx build @affine/native -- --target x86_64-apple-darwin --use-napi-cross
Sent with 💌 from NxCloud.
![nx-cloud[bot] avatar](https://avatars.githubusercontent.com/in/80458?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.32%. Comparing base (
90ef12e) to head (d1783b6). Report is 1 commits behind head on canary.
Additional details and impacted files
@@ Coverage Diff @@
## canary #8531 +/- ##
==========================================
+ Coverage 70.27% 70.32% +0.04%
==========================================
Files 534 534
Lines 33585 33585
Branches 3011 3011
==========================================
+ Hits 23602 23617 +15
+ Misses 9631 9617 -14
+ Partials 352 351 -1
| Flag | Coverage Δ | |
|---|---|---|
| server-test | 77.24% <ø> (+0.06%) |
:arrow_up: |
| unittest | 45.34% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
I think you can add a timer in
AppSidebarentity to prevent hovering = true when sidebar is just closed
Maybe it would be better to use the timer as little as possible?
Merge activity
- Oct 19, 8:33 AM EDT: A user added this pull request to the Graphite merge queue.
- Oct 19, 9:23 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Check yarn binary').
- Oct 20, 3:05 AM EDT: A user added this pull request to the Graphite merge queue.
- Oct 20, 3:18 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Desktop Test (macos-14, macos, arm64, aarch64-apple-darwin, true)', 'Desktop Test (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)', 'Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)').
- Oct 21, 1:13 AM EDT: A user added this pull request to the Graphite merge queue.
- Oct 21, 1:38 AM EDT: A user merged this pull request with the Graphite merge queue.