AFFiNE icon indicating copy to clipboard operation
AFFiNE copied to clipboard

Added responsiveness to the settings modal for mobile devices

Open WhiteSnek opened this issue 1 year ago • 6 comments

Description

This PR makes the settings modal responsive for mobile devices. It adjusts the layout, font sizes, and spacing to improve usability on smaller screens.

Changes

  • Added responsive styles to ensure the modal works well on mobile devices.
  • Updated layout and element sizes for better touch interaction and readability.

Before:

Screenshot 2024-10-12 at 21-25-02 AFFiNE

After:

Screenshot 2024-10-12 at 21-51-26 AFFiNE

WhiteSnek avatar Oct 12 '24 16:10 WhiteSnek

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 12 '24 16:10 CLAassistant

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

graphite-app[bot] avatar Oct 12 '24 16:10 graphite-app[bot]

View your CI Pipeline Execution ↗ for commit 7dfd8ecc19156f9f27adc9bed823d5d9aba939a7.

Command Status Duration Result
nx build @affine/native --verbose -- --target a... ❌ Failed <1s View ↗
nx build @affine/native --verbose -- --target x... ❌ Failed <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-02 09:28:47 UTC

nx-cloud[bot] avatar Oct 13 '24 00:10 nx-cloud[bot]

Random guy here 👋

  • the value for the display language appears to be missing in your "after", maybe its pushed too far to the left?
  • not a designer but if possible it would be nice if the modal was full screened (or at least smaller margins) for mobile devices no?

mrdjohnson avatar Dec 01 '24 03:12 mrdjohnson

Random guy here 👋

* the value for the display language appears to be missing in your "after", maybe its pushed too far to the left?

* not a designer but if possible it would be nice if the modal was full screened (or at least smaller margins) for mobile devices no?

you're right. i'll fix it

WhiteSnek avatar Dec 01 '24 09:12 WhiteSnek

@EYHN @mrdjohnson i've implemented the changes Screenshot 2024-12-01 154522

WhiteSnek avatar Dec 01 '24 10:12 WhiteSnek