AFFiNE icon indicating copy to clipboard operation
AFFiNE copied to clipboard

refactor(core): quick search extension and slash menu extension

Open fundon opened this issue 1 year ago • 5 comments

Closes BS-1412 AF-1086

fundon avatar Sep 12 '24 21:09 fundon

  • #8230 Graphite: 2 dependent PRs (#8253 Graphite, #8269 Graphite) 👈
  • #8227 Graphite
  • canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

fundon avatar Sep 12 '24 21:09 fundon

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

graphite-app[bot] avatar Sep 12 '24 21:09 graphite-app[bot]

Codecov Report

Attention: Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (canary@b73d3b3). Learn more about missing BASE report. Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ages/frontend/core/src/modules/navigation/utils.ts 68.00% 8 Missing :warning:
Additional details and impacted files
@@            Coverage Diff            @@
##             canary    #8230   +/-   ##
=========================================
  Coverage          ?   72.71%           
=========================================
  Files             ?      519           
  Lines             ?    32797           
  Branches          ?     2973           
=========================================
  Hits              ?    23847           
  Misses            ?     8919           
  Partials          ?       31           
Flag Coverage Δ
server-test 78.86% <ø> (?)
unittest 49.72% <68.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 12 '24 22:09 codecov[bot]

can you please also add a new e2e test?

👌

fundon avatar Sep 13 '24 01:09 fundon

Merge activity

graphite-app[bot] avatar Sep 18 '24 12:09 graphite-app[bot]