refactor(core): quick search extension and slash menu extension
Closes BS-1412 AF-1086
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @fundon and the rest of your teammates on
Graphite
☁️ Nx Cloud Report
CI is running/has finished running commands for commit f397815ad1f7e5afe07726a1bbaa6ea8a5cccded. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 6 targets
nx test:coverage @affine/monoreponx build @affine/native -- --target x86_64-pc-windows-msvc --use-napi-crossnx build @affine/native -- --target x86_64-unknown-linux-gnu --use-napi-crossnx build @affine/native -- --target aarch64-apple-darwin --use-napi-crossnx build @affine/native -- --target x86_64-apple-darwin --use-napi-crossnx build @affine/server-native -- --target x86_64-unknown-linux-gnu --use-napi-cross
Sent with 💌 from NxCloud.
Your org has enabled the Graphite merge queue for merging into canary
Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.
You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.
Codecov Report
Attention: Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.
Please upload report for BASE (
canary@b73d3b3). Learn more about missing BASE report. Report is 1 commits behind head on canary.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...ages/frontend/core/src/modules/navigation/utils.ts | 68.00% | 8 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## canary #8230 +/- ##
=========================================
Coverage ? 72.71%
=========================================
Files ? 519
Lines ? 32797
Branches ? 2973
=========================================
Hits ? 23847
Misses ? 8919
Partials ? 31
| Flag | Coverage Δ | |
|---|---|---|
| server-test | 78.86% <ø> (?) |
|
| unittest | 49.72% <68.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
can you please also add a new e2e test?
👌
Merge activity
- Sep 18, 8:10 AM EDT:
EYHNadded this pull request to the Graphite merge queue. - Sep 18, 8:23 AM EDT:
EYHNmerged this pull request with the Graphite merge queue.