AFFiNE icon indicating copy to clipboard operation
AFFiNE copied to clipboard

fix(component): windows client does not have app controls on some pages

Open JimmFly opened this issue 1 year ago • 4 comments

close AF-1266

JimmFly avatar Sep 09 '24 10:09 JimmFly

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

graphite-app[bot] avatar Sep 09 '24 10:09 graphite-app[bot]

  • #8176 Graphite 👈
  • canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

JimmFly avatar Sep 09 '24 10:09 JimmFly

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.46%. Comparing base (3999b04) to head (8e71815). Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...src/components/affine-other-page-layout/layout.tsx 0.00% 1 Missing :warning:
packages/frontend/core/src/pages/404.tsx 50.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8176      +/-   ##
==========================================
- Coverage   53.46%   53.46%   -0.01%     
==========================================
  Files        1259     1260       +1     
  Lines       49462    49466       +4     
  Branches     6004     6004              
==========================================
+ Hits        26446    26448       +2     
- Misses      22973    22975       +2     
  Partials       43       43              
Flag Coverage Δ
server-test 78.78% <ø> (ø)
unittest 25.85% <33.33%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 09 '24 10:09 codecov[bot]

we should find a better solution. it's not a good idea to add it for every page again and again

I moved it to the electron app component, which should work as you expect. @forehalo

JimmFly avatar Sep 12 '24 06:09 JimmFly

Merge activity

graphite-app[bot] avatar Sep 12 '24 06:09 graphite-app[bot]