feat: filter out empty workpace in sidebar list
fix PD-1567
Your org has enabled the Graphite merge queue for merging into canary
Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.
You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @darkskygit and the rest of your teammates on
Graphite
☁️ Nx Cloud Report
CI is running/has finished running commands for commit dde45748d967185d6135e3b8da245480c3d41bae. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 6 targets
nx test:coverage @affine/monoreponx build @affine/server-native -- --target x86_64-unknown-linux-gnu --use-napi-crossnx build @affine/native -- --target x86_64-pc-windows-msvc --use-napi-crossnx build @affine/native -- --target x86_64-apple-darwin --use-napi-crossnx build @affine/native -- --target aarch64-apple-darwin --use-napi-crossnx build @affine/native -- --target x86_64-unknown-linux-gnu --use-napi-cross
Sent with 💌 from NxCloud.
Codecov Report
Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.
Project coverage is 55.23%. Comparing base (
0668568) to head (dde4574). Report is 1 commits behind head on canary.
| Files | Patch % | Lines |
|---|---|---|
| .../server/src/core/workspaces/resolvers/workspace.ts | 33.33% | 10 Missing :warning: |
| .../component/src/components/workspace-list/index.tsx | 0.00% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## canary #7960 +/- ##
==========================================
+ Coverage 55.20% 55.23% +0.03%
==========================================
Files 1060 1060
Lines 44752 44768 +16
Branches 5276 5278 +2
==========================================
+ Hits 24705 24729 +24
+ Misses 19666 19658 -8
Partials 381 381
| Flag | Coverage Δ | |
|---|---|---|
| server-test | 77.65% <33.33%> (+0.04%) |
:arrow_up: |
| unittest | 27.11% <0.00%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Merge activity
- Aug 28, 4:43 AM EDT:
darkskygitadded this pull request to the Graphite merge queue. - Aug 28, 4:55 AM EDT:
darkskygitmerged this pull request with the Graphite merge queue.