AFFiNE icon indicating copy to clipboard operation
AFFiNE copied to clipboard

feat(core): add block and element toolbar widget custom config

Open fundon opened this issue 1 year ago • 4 comments

Upstreams: https://github.com/toeverything/blocksuite/pull/8001 https://github.com/toeverything/blocksuite/pull/7964

  • add block/element toolbar widget config
  • add Copy link to block to more menu on block/element toolbar
Screenshot 2024-08-16 at 16 20 08

fundon avatar Aug 15 '24 08:08 fundon

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

graphite-app[bot] avatar Aug 15 '24 08:08 graphite-app[bot]

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

fundon avatar Aug 15 '24 08:08 fundon

Codecov Report

Attention: Patch coverage is 2.38095% with 41 lines in your changes missing coverage. Please review.

Project coverage is 52.38%. Comparing base (ad11007) to head (c3ae219). Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...block-suite-editor/specs/custom/widgets/toolbar.ts 0.00% 41 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7886      +/-   ##
==========================================
- Coverage   52.48%   52.38%   -0.10%     
==========================================
  Files        1215     1218       +3     
  Lines       48208    48302      +94     
  Branches     5855     5880      +25     
==========================================
+ Hits        25300    25304       +4     
- Misses      22536    22626      +90     
  Partials      372      372              
Flag Coverage Δ
server-test 77.58% <ø> (ø)
unittest 25.29% <2.38%> (-0.09%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 15 '24 08:08 codecov[bot]

Thanks for them comments. If we want a friendlier API, we should invest some time and design it properly.

fundon avatar Sep 03 '24 00:09 fundon

Merge activity

graphite-app[bot] avatar Sep 03 '24 03:09 graphite-app[bot]