AFFiNE icon indicating copy to clipboard operation
AFFiNE copied to clipboard

[bug]: `Ctrl/⌘ + ?` should be replaced with `Ctrl/⌘ + K`

Open MarvinJWendt opened this issue 3 years ago • 5 comments

1~3 main use cases of the proposed improvement

As a person who is using a German keyboard, I cannot type the shortcut CTRL+?. The ? key does not exist on the German keyboard, and is a shortcut by itself (SHIFT+ß).

Ideas for solution

I propose to change the shortcut to something else. GitHub for example uses CTRL+K and CTRL+ALT+K inside text boxes to work around the conflict with creating a link.

what types of users can benefit from using your proposed improvement

users that use a non-english keyboard layout

Additional context

CTRL+K and CTRL+ALT+K are commonly used to search for other pages, and to open quick search menus.

MarvinJWendt avatar Jan 08 '23 14:01 MarvinJWendt

Hi, I wasn't sure if I should label this as a bug or as an improvement. I decided to choose improvement, because there is no broken feature. I hope that fits.

MarvinJWendt avatar Jan 08 '23 14:01 MarvinJWendt

Oh, it seems like CTRL+K is already working 😅 But it's not shown in the shortcuts help menu, maybe it can be added there?

MarvinJWendt avatar Jan 08 '23 14:01 MarvinJWendt

Thanks for your feedback! I'm a bit confused since I can see the CMD-K hint on latest AFFiNE Alpha page:

image

And it seems that we don't have a CMD-? binding, because in American keyboard layout, neither can we input a ? character without pressing SHIFT. Could the CMD/CTRL-K hotkey meet your needs for now?

doodlewind avatar Jan 08 '23 14:01 doodlewind

Hi, the alpha page has this paragraph:

image

Yes the CMD/CTRL-K fits, but the shortcut menu only shows CMD/CTRL-K for creating links, not for opening the quick search :)

MarvinJWendt avatar Jan 08 '23 15:01 MarvinJWendt

Hi there, this is actually a placeholder "?" and should have been replaced with "K". I thought this was resolved with #654, so thanks for bringing this up, we'll look to get it updated ASAP.

So to clarify "K" is the correct key, and not "?".

ShortCipher5 avatar Jan 09 '23 01:01 ShortCipher5

This has been resolved, thank you.

ShortCipher5 avatar Jan 10 '23 06:01 ShortCipher5