AFFiNE icon indicating copy to clipboard operation
AFFiNE copied to clipboard

feat(infra): di container

Open EYHN opened this issue 2 years ago • 3 comments

EYHN avatar Jan 02 '24 12:01 EYHN

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

graphite-app[bot] avatar Jan 02 '24 12:01 graphite-app[bot]

Current dependencies on/for this PR:

  • canary
    • PR #5562 Graphite
      • PR #5595 Graphite
      • PR #5497 Graphite 👈
        • PR #5563 Graphite
          • PR #5564 Graphite
            • PR #5693 Graphite
              • PR #5617 Graphite
                • PR #5618 Graphite
                  • PR #5565 Graphite

This stack of pull requests is managed by Graphite.

EYHN avatar Jan 02 '24 12:01 EYHN

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (c9f8e49) 64.59% compared to head (48eb6c5) 64.69%.

Files Patch % Lines
packages/common/infra/src/utils/stable-hash.ts 38.46% 13 Missing and 3 partials :warning:
packages/common/infra/src/di/core/collection.ts 82.27% 8 Missing and 6 partials :warning:
packages/common/infra/src/di/core/provider.ts 78.78% 10 Missing and 4 partials :warning:
packages/common/infra/src/di/react/index.ts 11.11% 8 Missing :warning:
packages/common/infra/src/di/core/identifier.ts 77.77% 1 Missing and 1 partial :warning:
packages/common/infra/src/di/core/error.ts 93.33% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5497      +/-   ##
==========================================
+ Coverage   64.59%   64.69%   +0.09%     
==========================================
  Files         298      306       +8     
  Lines       18423    18632     +209     
  Branches     1489     1542      +53     
==========================================
+ Hits        11901    12054     +153     
- Misses       6352     6392      +40     
- Partials      170      186      +16     
Flag Coverage Δ
server-test 70.91% <ø> (-0.01%) :arrow_down:
unittest 44.21% <73.68%> (+1.49%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 02 '24 12:01 codecov[bot]

Merge activity

graphite-app[bot] avatar Jan 30 '24 06:01 graphite-app[bot]