Fix:The pitch zooming function incorrectly zooms the toolbar #5293 #5294
The issue was having when the image is filling up the entire screen after zoomIn , so it was zooming in the background container as well . So , I have created a reference to check the zoomIn and zoomOut scale . And Checking that on handleScroll function.
https://github.com/toeverything/AFFiNE/assets/83939820/47b52692-527f-4ec6-b42f-9c72d4d48ac4
Fix:The pitch zooming function incorrectly zooms the toolbar #5293 #5294
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 6627f00f11adcfe8008770d1b09850e163e84f29. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 6 targets
nx test:coverage @affine/monoreponx build @affine/storage -- --target x86_64-unknown-linux-gnu --use-napi-crossnx build @affine/native -- --target x86_64-pc-windows-msvc --use-napi-crossnx build @affine/native -- --target x86_64-apple-darwin --use-napi-crossnx build @affine/native -- --target aarch64-apple-darwin --use-napi-crossnx build @affine/native -- --target x86_64-unknown-linux-gnu --use-napi-cross
Sent with 💌 from NxCloud.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
58ea2fb) 64.69% compared to head (6627f00) 64.60%.
Additional details and impacted files
@@ Coverage Diff @@
## canary #5456 +/- ##
==========================================
- Coverage 64.69% 64.60% -0.10%
==========================================
Files 358 358
Lines 19924 19924
Branches 1699 1698 -1
==========================================
- Hits 12889 12871 -18
- Misses 6816 6834 +18
Partials 219 219
| Flag | Coverage Δ | |
|---|---|---|
| server-test | 71.45% <ø> (-0.13%) |
:arrow_down: |
| unittest | 45.32% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.