z-index bug: when open a deleted page, button's tooltip was wrong

[hwangdev97]

What happened?

Distribution version

macOS x64 (Intel)

What browsers are you seeing the problem on if you're using web version?

No response

Relevant log output

No response

Anything else?

No response

Are you willing to submit a PR?

• [ ] Yes I'd like to help by submitting a PR!

[hwangdev97]

cc @JimmFly

[sandy088]

Hey @hwangdev97 I want to work on this, can you please assign it to me?

[pengx17]

Should be fixed by https://github.com/toeverything/AFFiNE/pull/5169 already

[sandy088]

Should be fixed by #5169 already

Hey @pengx17 @hwangdev97 ,

Ok, that's good, but @pengx17 kindly please can you tell me how this issue is being resolved, because I've been trying to fix the issue with the tooltip and z-index on the trash page. I've experimented with z-index on , tooltip, trash-page-button-groups, and help-island (possibly everywhere from where the Delete button's tooltip can affected), but it doesn't seem to be the problem, Z-index property is not working on all these places. It could be related to how the elements are placed, possibly due to nested stacking contexts.

I have a potential solution in mind: moving the tooltip to the left side of both the delete and restore buttons, as shown in the image. What do you think? Should I go ahead and make a pull request for this?

Let me know your thoughts...

[sandy088]

Should be fixed by #5169 already

Hey @pengx17 @hwangdev97

Still this issue is not fixed in #5169 can so, can I make a pull request with the above fixes that I have done?

[affine-issue-bot[bot]]

Issue Status: ✅ Done

✅ Done

If the issue was a bug, it’s been fixed; if it was a missing feature, it’s been implemented.

^{_{This is an automatic reply by the bot.}}