"Drag page to sidebar" does not work

[PaxtonXuan]

https://github.com/toeverything/AFFiNE/assets/134894293/9fcd7280-c391-4f8e-a9c9-e1fa0b7e53b3

[PaxtonXuan]

I heard this feature was possible before

[houjoe0829]

As our expectation:

1. Could drag and add to Favourites.
2. Could adjust the order in Favourites.

[teobler]

to support sortable list, there are several ways:

1. just like collection pages, we can save favorite pages as an array to idb
2. add an array or related data structure to workspace to support sorted list
3. add two fields like prevFavoritePage, nextFavoritePage to make pageMeta a linked list

not sure if there is more option we can choose. cc: @himself65

[himself65]

I believe this should be saved in the CRDT to sync to all clients. So you might need to know how to use workspace.meta

[teobler]

Sure, this is what I proposed in option 2, then I will create an array in workspace.meta maybe named favoritePages

[Garfield550]

@houjoe0829 Is this "drag and drop design" still effective?

[houjoe0829]

@houjoe0829 Is this "drag and drop design" still effective?

Thank you for your attention. This design draft has expired and requires @xell to update the new design for dragging to the sidebar.

[Garfield550]

@houjoe0829 Is this "drag and drop design" still effective?

Thank you for your attention. This design draft has expired and requires @xell to update the new design for dragging to the sidebar.

Okay, this issue is currently blocked. I will start working after the new design is completed.

[affine-issue-bot[bot]]

Issue Status: ✅ Done

✅ Done

If the issue was a bug, it’s been fixed; if it was a missing feature, it’s been implemented.

^{_{This is an automatic reply by the bot.}}