AFFiNE icon indicating copy to clipboard operation
AFFiNE copied to clipboard

refactor: move provider connection into atom

Open himself65 opened this issue 2 years ago • 6 comments

DO NOT MERGE, FATAL ERROR THAT DATA WILL BE LOST

Upstream: https://github.com/pmndrs/jotai/issues/2027

himself65 avatar Jul 06 '23 15:07 himself65

This branch is running in CodeSandbox. Use the links below to review this PR faster.
CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

codesandbox[bot] avatar Jul 06 '23 15:07 codesandbox[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 8:07am
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 8:07am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 8:07am

vercel[bot] avatar Jul 06 '23 15:07 vercel[bot]

Codecov Report

Patch coverage has no change and project coverage change: +11.83 :tada:

Comparison is base (152fbaa) 67.16% compared to head (622e68e) 79.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3075       +/-   ##
===========================================
+ Coverage   67.16%   79.00%   +11.83%     
===========================================
  Files         348       30      -318     
  Lines        8315     2072     -6243     
  Branches     1075       70     -1005     
===========================================
- Hits         5585     1637     -3948     
+ Misses       2441      435     -2006     
+ Partials      289        0      -289     
Flag Coverage Δ
e2etest ?
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 ?
e2etest-windows-latest-x64 ?
server-test 79.00% <ø> (ø)
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 318 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 06 '23 15:07 codecov[bot]

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 622e68e
Status:⚡️  Build in progress...

View logs

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …6/move-signal                 +/- ##
===================================================================
> Bundle              5.23 MB        5.23 MB      -466 B(-0.01%)   
> Initial JS          2.23 MB        2.23 MB      -877 B(-0.04%)   
= Initial CSS         71.1 kB        71.1 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   71             71                       
= Chunks                   56             56                       
= Packages                207            207                       
= Duplicates               19             19                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …6/move-signal                 +/- ##
===================================================================
> Bundle              5.12 MB        5.12 MB      -466 B(-0.01%)   
> Initial JS          2.12 MB        2.12 MB      -877 B(-0.04%)   
= Initial CSS         71.1 kB        71.1 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   69             69                       
= Chunks                   54             54                       
= Packages                207            207                       
= Duplicates               19             19                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …6/move-signal                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

perfsee[bot] avatar Jul 06 '23 15:07 perfsee[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 622e68ec521998a84e9b54266997a89b4c3f170f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Jul 06 '23 15:07 nx-cloud[bot]