AFFiNE icon indicating copy to clipboard operation
AFFiNE copied to clipboard

When using a custom storage path, the file name for storage is incorrect

Open hwangdev97 opened this issue 2 years ago • 4 comments

What happened?

report from twitter

F0P8juVaEAAmWrH

added the undefined name at the beginning.

Distribution version

macOS x64

What browsers are you seeing the problem on if you're using web version?

No response

Relevant log output

No response

Anything else?

No response

Are you willing to submit a PR?

  • [ ] Yes I'd like to help by submitting a PR!

hwangdev97 avatar Jul 05 '23 06:07 hwangdev97

https://github.com/toeverything/AFFiNE/blob/8a565b8633a1e72dc5a7fbd62089367b0adb000a/apps/electron/src/helper/dialog/dialog.ts#L101-L102

seems like db.getWorkspaceName() will return undefined

kanweiwei avatar Jul 06 '23 06:07 kanweiwei

image

It can be undefined sometimes. But i can't reproduced.

kanweiwei avatar Jul 06 '23 08:07 kanweiwei

@pengx17

himself65 avatar Jul 06 '23 11:07 himself65

It can be undefined sometimes. But i can't reproduced.

It seems there is some dataloss in the sqlite provider sometimes which will cause this issue. I am still investigating the issue.

pengx17 avatar Jul 06 '23 12:07 pengx17

Issue Status: ✅ Done

✅ Done

If the issue was a bug, it’s been fixed; if it was a missing feature, it’s been implemented.

This is an automatic reply by the bot.

affine-issue-bot[bot] avatar Mar 09 '24 10:03 affine-issue-bot[bot]