AFFiNE icon indicating copy to clipboard operation
AFFiNE copied to clipboard

feat: support subdoc for WebSocketProvider

Open thorseraq opened this issue 2 years ago • 6 comments

thorseraq avatar Jun 20 '23 09:06 thorseraq

This branch is running in CodeSandbox. Use the links below to review this PR faster.
CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

codesandbox[bot] avatar Jun 20 '23 09:06 codesandbox[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 2:31am
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 2:31am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 2:31am

vercel[bot] avatar Jun 20 '23 09:06 vercel[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1c116e73b3d183158455dfd3600a37430a4eda5c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx test:coverage @affine/monorepo
✅ Successfully ran 9 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Jun 20 '23 09:06 nx-cloud[bot]

Codecov Report

Patch coverage has no change and project coverage change: -9.55 :warning:

Comparison is base (d46b6c4) 63.03% compared to head (1c116e7) 53.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2831      +/-   ##
==========================================
- Coverage   63.03%   53.48%   -9.55%     
==========================================
  Files         357      317      -40     
  Lines        8254     6192    -2062     
  Branches     1103      829     -274     
==========================================
- Hits         5203     3312    -1891     
+ Misses       2769     2626     -143     
+ Partials      282      254      -28     
Flag Coverage Δ
e2etest 50.25% <0.00%> (+0.03%) :arrow_up:
e2etest-macos-latest-x64 ∅ <ø> (∅)
e2etest-ubuntu-latest-x64 42.92% <0.00%> (+0.01%) :arrow_up:
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-test ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/workspace/src/affine/keck/index.ts 2.43% <0.00%> (-70.64%) :arrow_down:

... and 114 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 20 '23 10:06 codecov[bot]

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1c116e7
Status: ✅  Deploy successful!
Preview URL: https://1d05076b.affine-dev.pages.dev
Branch Preview URL: https://feat-ws-subdoc.affine-dev.pages.dev

View logs

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master feat/ws-subdoc                 +/- ##
===================================================================
< Bundle              5.36 MB        5.36 MB      +760 B(+0.01%)   
< Initial JS          2.38 MB        2.38 MB      +760 B(+0.03%)   
= Initial CSS          113 kB         113 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   87             87                       
= Chunks                   68             68                       
= Packages                217            217                       
= Duplicates               16             16                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master feat/ws-subdoc                 +/- ##
===================================================================
< Bundle              5.23 MB        5.24 MB      +760 B(+0.01%)   
< Initial JS          2.26 MB        2.26 MB      +760 B(+0.03%)   
= Initial CSS          113 kB         113 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   85             85                       
= Chunks                   66             66                       
= Packages                217            217                       
= Duplicates               16             16                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master feat/ws-subdoc                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

perfsee[bot] avatar Jun 20 '23 10:06 perfsee[bot]

We are using socket.io now

Closed in https://github.com/toeverything/AFFiNE/pull/2881

himself65 avatar Jul 01 '23 03:07 himself65