AFFiNE icon indicating copy to clipboard operation
AFFiNE copied to clipboard

fix: add macOS hotkey support for pendant-modify-panel component

Open chenmoonmo opened this issue 1 year ago • 5 comments

when i edit options of a tag by the panel, I found the tooltip shows ' ctrl + backspcae' . And 'command + backspcae' can not delete a extra option. The PR make tooltip of closeIcon show '⌘ + backspace' in macOS and respond to it correctly.

chenmoonmo avatar Aug 16 '22 16:08 chenmoonmo

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 199498c4d2af76d6451e3b2cb8de5cb7366be2ae. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Aug 16 '22 16:08 nx-cloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Aug 16 '22 16:08 sonarcloud[bot]

Excuse me, the PR can work as expectation in Windows?

mitsuhatu avatar Aug 19 '22 02:08 mitsuhatu

Unfortunately this pr can't be adopted, the command + backspace shortcut combination is already used to quickly clear the input internal text

QiShaoXuan avatar Aug 19 '22 03:08 QiShaoXuan

But the ctrl + backspace shortcut is also a shortcut of system to remove last word in Windows, and control is not a common key in macOS. Perhaps the command key is not a better substitute, but the ctrl key does not fit the user's operating habits

chenmoonmo avatar Aug 19 '22 03:08 chenmoonmo