AFFiNE icon indicating copy to clipboard operation
AFFiNE copied to clipboard

build: support linux aarch64

Open himself65 opened this issue 2 years ago • 10 comments

Fixes: https://github.com/toeverything/AFFiNE/issues/2250

Actions: https://github.com/toeverything/AFFiNE/actions/runs/4904025222 Actions: https://github.com/toeverything/AFFiNE/actions/runs/4910525789

himself65 avatar May 06 '23 22:05 himself65

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 11:53pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 11:53pm

vercel[bot] avatar May 06 '23 22:05 vercel[bot]

Codecov Report

Patch coverage has no change and project coverage change: -0.04 :warning:

Comparison is base (1e8c5a4) 71.72% compared to head (5bd2d22) 71.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2251      +/-   ##
==========================================
- Coverage   71.72%   71.69%   -0.04%     
==========================================
  Files         296      296              
  Lines        6595     6595              
  Branches     1074     1074              
==========================================
- Hits         4730     4728       -2     
- Misses       1668     1670       +2     
  Partials      197      197              
Flag Coverage Δ
e2etest 69.25% <ø> (-0.05%) :arrow_down:
server-test 73.14% <ø> (ø)
storybook-test 55.14% <ø> (ø)
unittest 36.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 06 '23 23:05 codecov[bot]

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5bd2d22
Status: ✅  Deploy successful!
Preview URL: https://8200ab45.affine.pages.dev
Branch Preview URL: https://himself65-0506-linux-arm64.affine.pages.dev

View logs

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …6-linux-arm64                 +/- ##
===================================================================
< Bundle              3.11 MB        3.14 MB    +33.2 kB(+1.07%)   
< Initial JS          1.86 MB        1.87 MB    +11.2 kB(+0.60%)   
< Initial CSS         16.8 kB        18.3 kB    +1.54 kB(+9.19%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             45                  +4   
< Chunks                   39             42                  +3   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …6-linux-arm64                 +/- ##
===================================================================
< Bundle                 3 MB        3.02 MB    +23.8 kB(+0.79%)   
< Initial JS          1.75 MB        1.75 MB    +1.88 kB(+0.11%)   
< Initial CSS         16.8 kB        18.3 kB    +1.54 kB(+9.19%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             43                  +4   
< Chunks                   37             40                  +3   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …6-linux-arm64                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

perfsee[bot] avatar May 06 '23 23:05 perfsee[bot]

image

himself65 avatar May 06 '23 23:05 himself65

Cannot merge, since arch of better-sqlite3 is incorrect

himself65 avatar May 06 '23 23:05 himself65

Let me test the release on Linux simulator then merge this

himself65 avatar May 08 '23 01:05 himself65

Cannot merge

Oh I believe the issue is that sqlite bindings may need to build against linux arm64 as well

pengx17 avatar May 08 '23 02:05 pengx17

https://github.com/electron/rebuild/issues/378 Perhaps we need to follow some steps to configure node-gyp here

pengx17 avatar May 08 '23 02:05 pengx17

I'm not good at this, please handle this PR if you have time

himself65 avatar May 08 '23 03:05 himself65

stale PR, closing for now

himself65 avatar Aug 05 '23 04:08 himself65