AFFiNE icon indicating copy to clipboard operation
AFFiNE copied to clipboard

refactor: dblClick to mount editor

Open doouding opened this issue 9 months ago • 2 comments

doouding avatar Mar 20 '25 08:03 doouding


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

doouding avatar Mar 20 '25 08:03 doouding

Codecov Report

Attention: Patch coverage is 37.80488% with 153 lines in your changes missing coverage. Please review.

Project coverage is 54.35%. Comparing base (61c0d01) to head (ace5d44). Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...nector/src/text/edgeless-connector-label-editor.ts 9.37% 29 Missing :warning:
...e/gfx/shape/src/text/edgeless-shape-text-editor.ts 4.54% 21 Missing :warning:
...ksuite/affine/gfx/text/src/edgeless-text-editor.ts 20.83% 19 Missing :warning:
...cks/block-edgeless-text/src/edgeless-text-block.ts 33.33% 16 Missing :warning:
...ffine/blocks/block-note/src/note-edgeless-block.ts 50.00% 12 Missing :warning:
.../gfx/group/src/text/edgeless-group-title-editor.ts 8.33% 11 Missing :warning:
...ss/element-transform/dblclick-add-edgeless-text.ts 40.00% 9 Missing :warning:
...fine/widgets/widget-frame-title/src/frame-title.ts 22.22% 7 Missing :warning:
...suite/affine/blocks/block-frame/src/frame-block.ts 0.00% 4 Missing and 1 partial :warning:
blocksuite/affine/gfx/text/src/view.ts 55.55% 4 Missing :warning:
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #11036      +/-   ##
==========================================
+ Coverage   54.34%   54.35%   +0.01%     
==========================================
  Files        2547     2550       +3     
  Lines      115133   115251     +118     
  Branches    18726    18749      +23     
==========================================
+ Hits        62571    62649      +78     
- Misses      50611    51270     +659     
+ Partials     1951     1332     -619     
Flag Coverage Δ
server-test 78.88% <ø> (ø)
unittest 30.32% <21.95%> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 24 '25 09:03 codecov[bot]

Merge activity

graphite-app[bot] avatar Mar 26 '25 07:03 graphite-app[bot]