AFFiNE icon indicating copy to clipboard operation
AFFiNE copied to clipboard

fix(editor): no need to sync local selection from awareness

Open fundon opened this issue 9 months ago • 2 comments

  1. Local selection should be set directly without syncing from awareness.
  2. Fixed an error in the selection signal: Cycle detected.

fundon avatar Mar 04 '25 11:03 fundon


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

fundon avatar Mar 04 '25 11:03 fundon

Codecov Report

Attention: Patch coverage is 54.76190% with 19 lines in your changes missing coverage. Please review.

Project coverage is 53.47%. Comparing base (35bea20) to head (79343b9). Report is 2 commits behind head on canary.

Files with missing lines Patch % Lines
...ore/src/extension/selection/selection-extension.ts 50.00% 9 Missing :warning:
...ine/blocks/block-table/src/selection-controller.ts 0.00% 3 Missing :warning:
...fine/blocks/block-paragraph/src/paragraph-block.ts 60.00% 2 Missing :warning:
...fine/blocks/block-data-view/src/data-view-block.ts 50.00% 1 Missing :warning:
...k-root/src/edgeless/edgeless-root-preview-block.ts 0.00% 1 Missing :warning:
...ts/fragment-outline/src/body/outline-panel-body.ts 0.00% 1 Missing :warning:
.../framework/std/src/view/element/block-component.ts 66.66% 1 Missing :warning:
...mework/std/src/view/element/gfx-block-component.ts 66.66% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10611      +/-   ##
==========================================
- Coverage   53.48%   53.47%   -0.01%     
==========================================
  Files        2570     2570              
  Lines      116389   116368      -21     
  Branches    18977    18970       -7     
==========================================
- Hits        62253    62233      -20     
+ Misses      52836    52833       -3     
- Partials     1300     1302       +2     
Flag Coverage Δ
server-test 78.32% <ø> (ø)
unittest 29.39% <40.47%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 04 '25 11:03 codecov[bot]

When the slash menu is turned off, we need to refocus on the editor

fundon avatar Apr 02 '25 11:04 fundon