fix(editor): no need to sync local selection from awareness
- Local selection should be set directly without syncing from awareness.
- Fixed an error in the selection signal:
Cycle detected.
- #10611
👈 (View in Graphite) canary
How to use the Graphite Merge Queue
Add either label to this PR to merge it via the merge queue:
- merge - adds this PR to the back of the merge queue
- hotfix - for urgent hot fixes, skip the queue and merge this PR next
You must have a Graphite account in order to use the merge queue. Sign up using this link.
An organization admin has enabled the Graphite Merge Queue in this repository.
Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.
This stack of pull requests is managed by Graphite. Learn more about stacking.
Codecov Report
Attention: Patch coverage is 54.76190% with 19 lines in your changes missing coverage. Please review.
Project coverage is 53.47%. Comparing base (
35bea20) to head (79343b9). Report is 2 commits behind head on canary.
Additional details and impacted files
@@ Coverage Diff @@
## canary #10611 +/- ##
==========================================
- Coverage 53.48% 53.47% -0.01%
==========================================
Files 2570 2570
Lines 116389 116368 -21
Branches 18977 18970 -7
==========================================
- Hits 62253 62233 -20
+ Misses 52836 52833 -3
- Partials 1300 1302 +2
| Flag | Coverage Δ | |
|---|---|---|
| server-test | 78.32% <ø> (ø) |
|
| unittest | 29.39% <40.47%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
When the slash menu is turned off, we need to refocus on the editor