Todd Karin

Results 16 comments of Todd Karin

At the level of bishop88_xxx would be good enough for my purposes.

It would be nice to modify the code so that if fitting fails for some of the IV curves, the function returns nan for those entries. We can't always be...

That makes sense. `pvlib.ivtools.sdm.fit_desoto_sandia` is the functionality I want, would you be able to implement error handling and try/except so that a few problem IV curves don't stop the function...

I just tried using `fit_sandia_simple` and found an error: here's a MWE: https://github.com/DuraMAT/pvpro/blob/master/examples/nist-iv03_process.py Data available: https://github.com/DuraMAT/pvpro/tree/master/examples/data This is the IV curve that the algorithm failed on:

index was 617. Here is the iv curve you can copy/paste. voltage = np.array([ 0.34, 0.68, 1.02, 1.36, 1.7 , 2.04, 2.38, 2.72, 3.06, 3.4 , 3.74, 4.08, 4.42, 4.76,...

That solves it! We may want to consider adding the "drop nan" code to `fit_sandia_simple` so people can avoid these issues in the future. ![image](https://user-images.githubusercontent.com/18688594/118730118-ed380080-b7eb-11eb-81f2-bbf3a4abbf09.png)

I've run `fit_sandia_simple` on this dataset (see figure below). But there is (as expected) a correlation between the diode factor extracted and the saturation current ref. I think this is...

At certain times of year, it seems there is a tight relationship between n_diode and Isat: ![image](https://user-images.githubusercontent.com/18688594/119551703-c5e2b580-bd4e-11eb-9ace-2da328bdda4d.png) But other times of year, there is significant spread: ![image](https://user-images.githubusercontent.com/18688594/119551822-e7dc3800-bd4e-11eb-9089-b9cba4c9b018.png) But this can...

Temperature data is an RTD mounted to the back of the single module. There are 4 different sensors on the one module, I used the one mounted in the center.

I like `read_cec_modules` better than `read_sam`. I'm indifferent on `retrieve` vs. `read`. This would also be a great opportunity to rename parameters to standardization with [pvterms](https://duramat.github.io/pv-terms/).